changed the way files get resolved on mod install

to better handle fomod and it's required interactivity

Cargo.toml

@@ -6,11 +6,13 @@ edition = "2024"
 [dependencies]
 anyhow = "1.0.102"
 clap = { version = "4.5.60", features = ["derive"] }
+crossterm = "0.29.0"
 env_logger = "0.11.9"
 globset = "0.4.18"
 libloot = "0.29.0"
 log = "0.4.29"
 quick-xml = { version = "0.39.2", features = ["serde-types", "serialize"] }
+ratatui = "0.30.0"
 serde = { version = "1.0.228", features = ["derive"] }
 sevenz-rust2 = { version = "0.20.2" }
 thiserror = "2.0.18"

src/actions.rs

@@ -7,5 +7,5 @@ mod load_order;
 pub use activate::{ActivationError, activate_instance};
 pub use download::handle_nxm;
 pub use include::insert_mod_to_instance;
-pub use install::resolve_files_for_install;
+pub use install::{resolve_files_for_install, ResolveFileResult};
 pub use load_order::{LoadOrderError, create_loadorder};

src/actions/install.rs

@@ -4,30 +4,34 @@ use std::{
 };
 
 use globset::{Glob, GlobSet, GlobSetBuilder};
-use log::{debug, trace};
 
 use crate::{
-    fomod, install_prompt,
-    mod_config_installer::run_fomod_installer,
-    types::{ModConfig, ModFile, ModdedInstance, RootConfig},
+    fomod,
+    types::{ModConfig, ModFile, RootConfig},
     utils::{resolve_case_insensitive, walk_all_files},
 };
 
 pub fn resolve_files_for_install(
     root_config: &RootConfig,
-    instance: &ModdedInstance,
     mod_to_install: &ModConfig,
-) -> anyhow::Result<Vec<ModFile>> {
+) -> anyhow::Result<ResolveFileResult> {
     let mod_location = root_config.mod_location().join(mod_to_install.path());
 
-    let files = match determain_mod_kind(mod_to_install, &mod_location)? {
-        ModKind::Fomod(xml_path) => install_fomod(instance, xml_path, &mod_location)?,
-        ModKind::EmbeddedData(_data_path) => install_from_dir(mod_to_install, mod_location)?,
-        ModKind::Root => install_root(mod_to_install, mod_location)?,
-        ModKind::Unkown => install_from_dir_to_data(mod_to_install, mod_location)?,
+    let result = match determain_mod_kind(mod_to_install, &mod_location)? {
+        ModKind::Fomod(xml_path) => {
+            let module_config = fomod::Config::load_from_file(xml_path)?;
+            ResolveFileResult::Fomod(module_config)
+        }
+        ModKind::EmbeddedData(_data_path) => {
+            ResolveFileResult::Files(install_from_dir(mod_to_install, mod_location)?)
+        }
+        ModKind::Root => ResolveFileResult::Files(install_root(mod_to_install, mod_location)?),
+        ModKind::Unkown => {
+            ResolveFileResult::Files(install_from_dir_to_data(mod_to_install, mod_location)?)
+        }
     };
 
-    Ok(files)
+    Ok(result)
 }
 
 fn determain_mod_kind(
@@ -51,32 +55,38 @@ fn determain_mod_kind(
     }
 }
 
-fn install_fomod(
-    instance: &ModdedInstance,
-    module_config_path: impl AsRef<Path>,
-    mod_root: impl AsRef<Path>,
-) -> anyhow::Result<Vec<ModFile>> {
-    debug!("Running FOmod installer");
-    let module_config = fomod::Config::load_from_file(module_config_path)?;
-
-    let active_plugins: Vec<_> = instance
-        .active_plugins()
-        .map(|e| e.to_string_lossy())
-        .map(|e| e.to_string())
-        .collect();
-
-    trace!("Current loded plugins: {:?}", active_plugins);
-    let files = run_fomod_installer(module_config, &active_plugins, install_prompt::prompt)?;
-
-    let mod_files: Vec<_> = files
-        .iter()
-        .map(|f| ModFile::from_installer(f.clone(), &mod_root))
-        .collect::<Result<Vec<_>, _>>()?
-        .into_iter()
-        .flatten()
-        .collect();
-    Ok(mod_files)
-}
+// fn install_fomod(
+//     instance: &ModdedInstance,
+//     module_config_path: impl AsRef<Path>,
+//     mod_root: impl AsRef<Path>,
+// ) -> anyhow::Result<Vec<ModFile>> {
+//     debug!("Running FOmod installer");
+//     let module_config = fomod::Config::load_from_file(module_config_path)?;
+//
+//     let active_plugins: Vec<_> = instance
+//         .active_plugins()
+//         .map(|e| e.to_string_lossy())
+//         .map(|e| e.to_string())
+//         .collect();
+//
+//     trace!("Current loded plugins: {:?}", active_plugins);
+//
+//     let mut installer = FomodInstaller::new(&module_config, &active_plugins);
+//     let mut selection: Option<Vec<usize>> = None;
+//     while let Some(prompt) = installer.run_step(selection.as_deref()) {
+//         selection = Some(install_prompt::prompt(prompt));
+//     }
+//     let files = installer.finalize();
+//
+//     let mod_files: Vec<_> = files
+//         .iter()
+//         .map(|f| ModFile::from_installer(f.clone(), &mod_root))
+//         .collect::<Result<Vec<_>, _>>()?
+//         .into_iter()
+//         .flatten()
+//         .collect();
+//     Ok(mod_files)
+// }
 
 fn install_from_dir(
     mod_config: &ModConfig,
@@ -143,6 +153,11 @@ enum ModKind {
     Unkown,
 }
 
+pub enum ResolveFileResult {
+    Files(Vec<ModFile>),
+    Fomod(fomod::Config),
+}
+
 fn should_be_included(path: impl AsRef<Path>) -> bool {
     matches!(
         path.as_ref().extension().and_then(|e| e.to_str()),

src/cli.rs

@@ -19,4 +19,5 @@ pub enum Commands {
     LoadOrder { instance: String },
     ApiCheck,
     Download { url: String },
+    Tui,
 }

src/lib.rs

@@ -8,3 +8,4 @@ pub mod types;
 pub mod unpacker;
 pub mod utils;
 pub mod actions;
+pub mod tui;

src/main.rs

@@ -5,11 +5,13 @@ use std::{error::Error, path::Path};
 
 use fomod_manager::{
     actions::{
-        activate_instance, create_loadorder, handle_nxm, insert_mod_to_instance,
+        ResolveFileResult, activate_instance, create_loadorder, handle_nxm, insert_mod_to_instance,
         resolve_files_for_install,
     },
     cli::{self, Args},
+    mod_config_installer::FomodInstaller,
     nexus::NexusAPI,
+    tui,
     types::RootConfig,
 };
 
@@ -29,7 +31,19 @@ fn command_add(root_config: &RootConfig, instance_id: &str, mod_id: &str) -> any
         .mod_by_id(mod_id)
         .ok_or(anyhow!("Can't find mod in config"))?;
 
-    let files = resolve_files_for_install(root_config, &instance, &mod_to_install)?;
+    let files = match resolve_files_for_install(root_config, &mod_to_install)? {
+        ResolveFileResult::Files(mod_files) => mod_files,
+        ResolveFileResult::Fomod(module_config) => {
+            let mod_location = root_config.mod_location().join(mod_to_install.path());
+            let active_plugins: Vec<String> = instance.active_plugins().collect();
+            let mut installer = FomodInstaller::new(&module_config, &active_plugins);
+            let mut selection: Option<Vec<usize>> = None;
+            while let Some(prompt) = installer.run_step(selection.as_deref()) {
+                selection = Some(fomod_manager::install_prompt::prompt(prompt));
+            }
+            installer.finalize(mod_location)?
+        }
+    };
 
     match insert_mod_to_instance(&mut instance, &mod_to_install, &files, 0) {
         None => {
@@ -71,7 +85,7 @@ fn command_download(root_config: &mut RootConfig, raw_url: &str) -> anyhow::Resu
 
 fn setup_logger() {
     env_logger::builder()
-        .filter_level(log::LevelFilter::max())
+        .filter_level(log::LevelFilter::Off)
         .format_timestamp(None)
         .filter_module("ureq_proto::util", log::LevelFilter::Debug)
         .filter_module("rustls::client::hs", log::LevelFilter::Debug)
@@ -102,6 +116,9 @@ fn main() -> Result<(), Box<dyn Error>> {
         cli::Commands::Download { url } => {
             command_download(&mut root_config, &url)?;
         }
+        cli::Commands::Tui => {
+            tui::run(&mut root_config)?;
+        }
     }
 
     Ok(())

src/mod_config_installer.rs

@@ -1,10 +1,13 @@
-use std::{collections::HashMap, fmt::Display};
+use std::{collections::HashMap, fmt::Display, io, path::Path};
 
 use log::{debug, warn};
 
-use crate::fomod::{
-    CompositeDependency, Config, DependencyOperator, DependencyState, FileList, FileTypeEnum,
-    Group, GroupType, ModuleDependency, Plugin, PluginTypeDescriptorEnum, PluginTypeEnum,
+use crate::{
+    fomod::{
+        CompositeDependency, Config, DependencyOperator, DependencyState, FileList, FileTypeEnum,
+        Group, GroupType, ModuleDependency, Plugin, PluginTypeDescriptorEnum, PluginTypeEnum,
+    },
+    types::ModFile,
 };
 
 #[derive(Debug)]
@@ -117,6 +120,7 @@ fn evaluate_module_depbendecy(
     }
 }
 
+#[derive(Debug)]
 pub struct GroupPrompt {
     pub name: String,
     pub select_type: GroupType,
@@ -146,6 +150,7 @@ impl GroupPrompt {
     }
 }
 
+#[derive(Debug)]
 pub struct InstallOption {
     pub name: String,
     pub option_type: PluginTypeEnum,
@@ -191,66 +196,90 @@ fn resolve_plugin_type(
     }
 }
 
-pub fn run_fomod_installer(
-    fomod_config: Config,
-    installed_plugins: &[String],
-    group_prompt: fn(GroupPrompt) -> Vec<usize>,
-) -> anyhow::Result<Vec<FileTypeEnum>> {
-    let mut state = InstallerState::new();
+pub struct FomodInstaller<'a> {
+    state: InstallerState,
+    current_step: (usize, usize),
+    config: &'a Config,
+    installed_plugins: &'a [String],
+}
 
-    // Always-installed files first
-    if let Some(required) = &fomod_config.required_install_files {
-        state.add_files(required);
+impl<'a> FomodInstaller<'a> {
+    pub fn new(fomod_config: &'a Config, installed_plugins: &'a [String]) -> Self {
+        let mut state = InstallerState::new();
+        if let Some(required) = &fomod_config.required_install_files {
+            state.add_files(required);
+        }
+
+        Self {
+            state,
+            current_step: (0, 0),
+            config: fomod_config,
+            installed_plugins,
+        }
     }
 
-    if let Some(install_steps) = fomod_config.install_steps {
-        let steps = &install_steps.install_step;
+    pub fn run_step(&mut self, selection: Option<&[usize]>) -> Option<GroupPrompt> {
+        let Some(install_steps) = &self.config.install_steps else {
+            return None;
+        };
 
-        for step in steps {
-            // Check if the step should be visible
-            if step
-                .visible
-                .as_ref()
-                .is_some_and(|v| !evaluate_module_depbendecy(v, &state, installed_plugins))
-            {
-                // Dependency to show the step not meet. Skipping.
-                continue;
-            }
+        let step = install_steps.install_step.get(self.current_step.0)?;
 
-            for group in &step.optional_file_groups.group {
-                // TODO: Skip groups where all plugins are NotUsable
+        // Check if the step should be visible
+        if step
+            .visible
+            .as_ref()
+            .is_some_and(|v| !evaluate_module_depbendecy(v, &self.state, self.installed_plugins))
+        {
+            // Dependency to show the step not meet. Skipping.
+            self.current_step = (self.current_step.0 + 1, 0);
+            return self.run_step(selection);
+        }
 
-                let prompt = GroupPrompt::new(group, &state, installed_plugins);
+        let Some(group) = step.optional_file_groups.group.get(self.current_step.1) else {
+            self.current_step = (self.current_step.0 + 1, 0);
+            return self.run_step(selection);
+        };
 
-                let selected_plugins = (group_prompt)(prompt);
+        // TODO: Skip groups where all plugins are NotUsable
 
+        match selection {
+            Some(selected_plugins) => {
                 for i in selected_plugins {
-                    let plugin = &group.plugins.plugin[i];
+                    let plugin = &group.plugins.plugin[*i];
 
                     // Add files from selected plugin
                     if let Some(files) = &plugin.files {
-                        state.add_files(files);
+                        self.state.add_files(files);
                     }
 
                     // Set condition flags
                     if let Some(condition_flags) = &plugin.condition_flags {
                         for flag in &condition_flags.flag {
-                            state.set_flag(&flag.name, &flag.flag_value);
+                            self.state.set_flag(&flag.name, &flag.flag_value);
                         }
                     }
                 }
+
+                // Next step
+                self.current_step = (self.current_step.0, self.current_step.1 + 1);
+                self.run_step(None)
             }
+            None => Some(GroupPrompt::new(group, &self.state, self.installed_plugins)),
         }
     }
 
-    // Evaluate conditional file installs based on final flag state
-    if let Some(conditional) = &fomod_config.conditional_file_installs {
-        for pattern in &conditional.patterns.pattern {
-            if evaluate_module_depbendecy(&pattern.dependencies, &state, installed_plugins) {
-                state.add_files(&pattern.files);
-            }
-        }
-    }
+    pub fn finalize(self, mod_root: impl AsRef<Path>) -> Result<Vec<ModFile>, io::Error> {
+        let files: Vec<_> = self
+            .state
+            .into_file_list()
+            .iter()
+            .map(|f| ModFile::from_installer(f.clone(), &mod_root))
+            .collect::<Result<Vec<_>, _>>()?
+            .into_iter()
+            .flatten()
+            .collect();
 
-    Ok(state.into_file_list())
+        Ok(files)
+    }
 }

src/tui.rs

@@ -0,0 +1,6 @@
+mod app;
+mod mod_list;
+mod status;
+mod instance;
+
+pub use app::run;

src/tui/app.rs

@@ -0,0 +1,137 @@
+use std::io;
+
+use crossterm::event::{self, Event, KeyCode, KeyEvent, KeyEventKind};
+use log::error;
+use ratatui::{
+    DefaultTerminal, Frame,
+    layout::{Constraint, Direction, Layout, Rect},
+    widgets::{StatefulWidget, Widget},
+};
+
+use crate::{
+    tui::{
+        instance::{InstanceSelect, InstanceSelectState},
+        mod_list::{ModList, ModListState},
+        status::StatusBar,
+    },
+    types::{ModdedInstance, RootConfig},
+};
+
+pub fn run(root_config: &mut RootConfig) -> anyhow::Result<()> {
+    ratatui::run(|terminal| App::new(root_config).run(terminal))?;
+    Ok(())
+}
+
+#[derive(Debug)]
+struct App<'a> {
+    root_config: &'a mut RootConfig,
+
+    loaded_instance: Option<ModdedInstance>,
+
+    exit: bool,
+
+    mod_list_state: ModListState,
+    selected_instance_state: InstanceSelectState,
+}
+
+impl<'a> App<'a> {
+    fn new(root_config: &'a mut RootConfig) -> Self {
+        let mut mod_list_state = ModListState::new();
+        mod_list_state.update_list(root_config, None);
+        Self {
+            root_config,
+
+            loaded_instance: None,
+
+            exit: false,
+            mod_list_state,
+            selected_instance_state: InstanceSelectState::new(),
+        }
+    }
+
+    pub fn run(&mut self, terminal: &mut DefaultTerminal) -> io::Result<()> {
+        terminal.clear()?;
+        while !self.exit {
+            terminal.draw(|frame| self.draw(frame))?;
+            self.handle_events()?;
+        }
+        Ok(())
+    }
+
+    fn draw(&mut self, frame: &mut Frame) {
+        frame.render_widget(self, frame.area());
+    }
+
+    fn handle_events(&mut self) -> io::Result<()> {
+        match event::read()? {
+            Event::Key(key_event) if key_event.kind == KeyEventKind::Press => {
+                self.handle_key_event(key_event)
+            }
+            _ => {}
+        };
+        Ok(())
+    }
+
+    fn handle_key_event(&mut self, key_event: KeyEvent) {
+        match key_event.code {
+            KeyCode::Esc | KeyCode::Char('q') => self.exit(),
+            KeyCode::Up | KeyCode::Char('k') => {
+                self.mod_list_state.select_prev();
+            }
+            KeyCode::Down | KeyCode::Char('j') => {
+                self.mod_list_state.select_next();
+            }
+            KeyCode::Right | KeyCode::Char('l') => {
+                self.selected_instance_state.next_instance(self.root_config);
+                self.load_instance();
+            }
+            KeyCode::Left | KeyCode::Char('h') => {
+                self.selected_instance_state.prev_instance(self.root_config);
+                self.load_instance();
+            }
+            _ => {}
+        }
+    }
+
+    fn exit(&mut self) {
+        self.exit = true;
+    }
+
+    fn load_instance(&mut self) {
+        let Some(selected) = self.selected_instance_state.instance() else {
+            return;
+        };
+
+        match self.root_config.load_instance_by_id(selected) {
+            Ok(instance) => {
+                self.loaded_instance = Some(instance);
+                self.mod_list_state
+                    .update_list(self.root_config, self.loaded_instance.as_ref());
+            }
+            Err(err) => {
+                error!("Failed to load instance: {err}");
+                self.exit();
+            }
+        }
+    }
+}
+
+impl<'a> Widget for &mut App<'a> {
+    fn render(self, area: Rect, buf: &mut ratatui::prelude::Buffer)
+    where
+        Self: Sized,
+    {
+        let chunks = Layout::default()
+            .direction(Direction::Vertical)
+            .constraints([
+                Constraint::Length(3),
+                Constraint::Min(1),
+                Constraint::Length(1),
+            ])
+            .split(area);
+
+        InstanceSelect.render(chunks[0], buf, &mut self.selected_instance_state);
+        ModList.render(chunks[1], buf, &mut self.mod_list_state);
+        StatusBar.render(chunks[2], buf);
+    }
+}

src/tui/instance.rs

@@ -0,0 +1,92 @@
+use ratatui::{
+    buffer::Buffer,
+    layout::Rect,
+    style::Style,
+    widgets::{Block, Borders, Paragraph, StatefulWidget, Widget},
+};
+
+use crate::types::RootConfig;
+
+#[derive(Debug)]
+pub struct InstanceSelectState {
+    selected: Option<String>,
+}
+
+impl InstanceSelectState {
+    pub fn new() -> Self {
+        Self { selected: None }
+    }
+
+    pub fn instance(&self) -> Option<&str> {
+        self.selected.as_deref()
+    }
+
+    pub fn next_instance(&mut self, root_config: &RootConfig) {
+        let mut instances = root_config.instances();
+        instances.sort();
+
+        if instances.is_empty() {
+            self.selected = None;
+            return;
+        }
+
+        let next = match &self.selected {
+            None => instances.first().cloned(),
+            Some(curr) => {
+                let idx = instances.iter().position(|x| x == curr);
+                match idx {
+                    Some(i) => {
+                        let next_index = (i + 1) % instances.len();
+                        instances.get(next_index).cloned()
+                    }
+                    None => instances.first().cloned(),
+                }
+            }
+        };
+
+        self.selected = next;
+    }
+
+    pub fn prev_instance(&mut self, root_config: &RootConfig) {
+        let mut instances = root_config.instances();
+        instances.sort();
+
+        if instances.is_empty() {
+            self.selected = None;
+            return;
+        }
+
+        let prev = match &self.selected {
+            None => instances.last().cloned(),
+            Some(curr) => {
+                let idx = instances.iter().position(|x| x == curr);
+                match idx {
+                    Some(i) => {
+                        let prev_index = if i == 0 { instances.len() - 1 } else { i - 1 };
+                        instances.get(prev_index).cloned()
+                    }
+                    None => Some(instances[instances.len() - 1].clone()),
+                }
+            }
+        };
+
+        self.selected = prev;
+    }
+}
+
+pub struct InstanceSelect;
+
+impl StatefulWidget for InstanceSelect {
+    type State = InstanceSelectState;
+
+    fn render(self, area: Rect, buf: &mut Buffer, state: &mut Self::State) {
+        let list_block = Block::default()
+            .title("Instance")
+            .borders(Borders::ALL)
+            .style(Style::default());
+
+        Paragraph::new(state.selected.clone().unwrap_or("None".to_owned()))
+            .block(list_block)
+            .render(area, buf);
+    }
+}

src/tui/mod_list.rs

@@ -0,0 +1,114 @@
+use std::collections::HashSet;
+
+use ratatui::{
+    buffer::Buffer,
+    layout::{Constraint, Rect},
+    style::{Color, Modifier, Style},
+    widgets::{Block, Borders, Cell, Row, StatefulWidget, Table, TableState},
+};
+
+use crate::types::{ModConfig, ModdedInstance, RootConfig};
+
+#[derive(Debug)]
+pub struct ModListState {
+    table_state: TableState,
+    items: Vec<ListItem>,
+}
+
+impl ModListState {
+    pub fn new() -> Self {
+        Self {
+            table_state: TableState::new(),
+            items: Vec::new(),
+        }
+    }
+
+    pub fn select_next(&mut self) {
+        self.table_state.select_next();
+    }
+
+    pub fn select_prev(&mut self) {
+        self.table_state.select_previous();
+    }
+
+    pub fn update_list(
+        &mut self,
+        root_config: &RootConfig,
+        loaded_instance: Option<&ModdedInstance>,
+    ) {
+        let instance_game_type = loaded_instance
+            .and_then(|e| root_config.game_by_id(e.game_id()))
+            .map(|e| e.game_type());
+
+        let included_ids: Option<HashSet<_>> =
+            loaded_instance.map(|instance| instance.mods().iter().map(|m| m.mod_id()).collect());
+
+        let mut items: Vec<_> = root_config
+            .mods()
+            .iter()
+            .filter(|e| instance_game_type.clone().is_none_or(|gt| e.1.game() == gt))
+            .map(|(id, config)| ListItem {
+                id: id.to_owned(),
+                mod_config: config.clone(),
+                included: included_ids
+                    .as_ref()
+                    .is_some_and(|set| set.contains(id.as_str())),
+            })
+            .collect();
+
+        items.sort_by_key(|item| item.id.clone());
+
+        self.items = items;
+    }
+}
+
+#[derive(Debug)]
+struct ListItem {
+    mod_config: ModConfig,
+    id: String,
+    included: bool,
+}
+
+#[derive(Debug)]
+pub struct ModList;
+
+impl StatefulWidget for ModList {
+    type State = ModListState;
+
+    fn render(self, area: Rect, buf: &mut Buffer, state: &mut Self::State) {
+        let block = Block::default()
+            .title("Mod list")
+            .borders(Borders::ALL)
+            .style(Style::default());
+
+        let rows: Vec<Row> = state
+            .items
+            .iter()
+            .map(|item| {
+                Row::new(vec![
+                    Cell::from(item.mod_config.name().unwrap_or(&item.id)),
+                    Cell::from(item.id.as_str()),
+                    Cell::from(if item.included { "" } else { "" }),
+                ])
+            })
+            .collect();
+
+        let table = Table::new(
+            rows,
+            [
+                Constraint::Fill(1),
+                Constraint::Fill(1),
+                Constraint::Fill(1),
+            ],
+        )
+        .row_highlight_style(
+            Style::default()
+                .fg(Color::Yellow)
+                .bg(Color::DarkGray)
+                .add_modifier(Modifier::BOLD),
+        )
+        .block(block);
+
+        StatefulWidget::render(table, area, buf, &mut state.table_state);
+    }
+}

src/tui/status.rs

@@ -0,0 +1,12 @@
+use ratatui::{text::Line, widgets::Widget};
+
+pub struct StatusBar;
+
+impl Widget for StatusBar {
+    fn render(self, area: ratatui::prelude::Rect, buf: &mut ratatui::prelude::Buffer)
+    where
+        Self: Sized {
+
+        Line::from("Up Down Left right").render(area, buf);
+    }
+}

src/types/mod_config.rs

@@ -93,6 +93,10 @@ impl ModConfig {
     pub fn nexus_id(&self) -> Option<&NexusID> {
         self.nexus_id.as_ref()
     }
+
+    pub fn game(&self) -> GameType {
+        self.game.clone()
+    }
 }
 
 fn is_false(b: &bool) -> bool {

src/types/modded_instance.rs

@@ -1,5 +1,4 @@
 use std::{
-    ffi::OsStr,
     fs::{self, read_to_string},
     io::Write,
     path::{Path, PathBuf},
@@ -106,8 +105,12 @@ impl ModdedInstance {
         &self.mods
     }
 
-    pub fn active_plugins(&self) -> impl Iterator<Item = &OsStr> {
-        self.mods.iter().flat_map(|e| e.active_plugins())
+    pub fn active_plugins(&self) -> impl Iterator<Item = String> {
+        self.mods
+            .iter()
+            .flat_map(|e| e.active_plugins())
+            .map(|e| e.to_string_lossy())
+            .map(|e| e.to_string())
     }
 }
 
@@ -156,6 +159,5 @@ mod tests {
         let new_mod = InstalledMod::new("mod1", 1);
 
         cfg.update_or_create_mod(&new_mod);
-
     }
 }

src/types/root_config.rs

@@ -87,10 +87,18 @@ impl RootConfig {
         self.mods.get(id).map(|e| e.clone().add_id(id))
     }
 
+    pub fn mods(&self) -> &HashMap<String, ModConfig> {
+        &self.mods
+    }
+
     pub fn add_mod(&mut self, new_mod: &ModConfig) {
         self.mods.insert(new_mod.id().to_owned(), new_mod.clone());
     }
 
+    pub fn instances(&self) -> Vec<String> {
+        self.instances.keys().cloned().collect()
+    }
+
     pub fn load_instance_by_id(&self, id: &str) -> Result<ModdedInstance, ConfigReadWriteError> {
         debug!("Loading instance {}", id);
         let conf = self

tests/add_mod_test.rs

@@ -20,7 +20,12 @@ fn add_plain() -> Result<(), Box<dyn Error>> {
     let mod_to_install = root_config
         .mod_by_id("add_test_plain")
         .expect("Mod not found");
-    let files_to_add = resolve_files_for_install(&root_config, &instance, &mod_to_install)?;
+    let files_to_add = match resolve_files_for_install(&root_config, &mod_to_install)? {
+        fomod_manager::actions::ResolveFileResult::Files(mod_files) => mod_files,
+        _ => {
+            panic!("Resolved files have wrong type");
+        }
+    };
 
     insert_mod_to_instance(&mut instance, &mod_to_install, &files_to_add, 0);
 
@@ -53,7 +58,12 @@ fn add_nested() -> Result<(), Box<dyn Error>> {
     let mod_to_install = root_config
         .mod_by_id("add_test_nested")
         .expect("Mod not found");
-    let files_to_add = resolve_files_for_install(&root_config, &instance, &mod_to_install)?;
+    let files_to_add = match resolve_files_for_install(&root_config, &mod_to_install)? {
+        fomod_manager::actions::ResolveFileResult::Files(mod_files) => mod_files,
+        _ => {
+            panic!("Resolved files have wrong type");
+        }
+    };
 
     insert_mod_to_instance(&mut instance, &mod_to_install, &files_to_add, 0);
 
@@ -86,7 +96,12 @@ fn add_root() -> Result<(), Box<dyn Error>> {
     let mod_to_install = root_config
         .mod_by_id("add_test_root")
         .expect("Mod not found");
-    let files_to_add = resolve_files_for_install(&root_config, &instance, &mod_to_install)?;
+    let files_to_add = match resolve_files_for_install(&root_config, &mod_to_install)? {
+        fomod_manager::actions::ResolveFileResult::Files(mod_files) => mod_files,
+        _ => {
+            panic!("Resolved files have wrong type");
+        }
+    };
 
     insert_mod_to_instance(&mut instance, &mod_to_install, &files_to_add, 0);
 
@@ -117,7 +132,12 @@ fn add_filter() -> Result<(), Box<dyn Error>> {
     let mod_to_install = root_config
         .mod_by_id("add_test_filter")
         .expect("Mod not found");
-    let files_to_add = resolve_files_for_install(&root_config, &instance, &mod_to_install)?;
+    let files_to_add = match resolve_files_for_install(&root_config, &mod_to_install)? {
+        fomod_manager::actions::ResolveFileResult::Files(mod_files) => mod_files,
+        _ => {
+            panic!("Resolved files have wrong type");
+        }
+    };
 
     insert_mod_to_instance(&mut instance, &mod_to_install, &files_to_add, 0);