refactored Redstone bin

src/bin/Disk.hx

@@ -1,24 +1,14 @@
 package bin;
 
-import kernel.ps.ProcessHandle;
-import kernel.ps.Process;
+import lib.CLIAppBase;
 import kernel.peripherals.Peripherals.Peripheral;
 
 using tink.CoreApi;
 using Lambda;
 
-class Disk implements Process {
-	private var handle:ProcessHandle;
-
-	public function new() {}
-
-	public function run(handle:ProcessHandle):Void {
-		this.handle = handle;
-		var subcommand = handle.args[0];
-		var driveAddr:Null<String> = handle.args[1];
-
-		switch (subcommand) {
-			case "ls":
+class Disk extends CLIAppBase {
+	public function new() {
+		registerSyncSubcommand("ls", (args)->{
 			Peripheral.instance.getDrives().foreach(drive -> {
 				var addr = drive.getAddr();
 				var label = drive.getDiskLabel();
@@ -36,54 +26,58 @@ class Disk implements Process {
 
 				return true;
 			});
-			case "play":
-				var drive = Peripheral.instance.getDrive(driveAddr);
-
-				if (drive == null){
-					handle.writeLine("Drive not found: " + driveAddr);
-				}
-
-				if (!drive.isDiskPresent()){
-					handle.writeLine("No disk in drive: " + driveAddr);
-				}
-
-				if (!drive.hasAudio()){
-					handle.writeLine("Disk in drive " + driveAddr + " does not have audio");
-				}
-
-				drive.playAudio();
-			case "stop":
-				var drive = Peripheral.instance.getDrive(driveAddr);
-
-				if (drive == null){
-					handle.writeLine("Drive not found: " + driveAddr);
-				}
-
-				if (!drive.isDiskPresent()){
-					handle.writeLine("No disk in drive: " + driveAddr);
-				}
-
-				if (!drive.hasAudio()){
-					handle.writeLine("Disk in drive: " + driveAddr + " does not have audio");
-				}
-
-				drive.stopAudio();
-
-			case "eject":
+		});
+
+		registerSyncSubcommand("play", (args)->{
+			if (args.length < 1){
+				handle.writeLine("Missing drive address");
+				return false;
+			}
+
+			return audioDiskPlayPause(args[0], true);
+		},"<drive>");
+
+		registerSyncSubcommand("stop", (args) -> {
+			if (args.length < 1){
+				handle.writeLine("Missing drive address");
+				return false;
+			}
+
+			return audioDiskPlayPause(args[0], false);
+		});
+
+		registerSyncSubcommand("eject", (args)->{
+			if (args.length < 1){
+				handle.writeLine("Missing drive address");
+				return false;
+			}
+
+			var driveAddr = args[0];
 			var drive = Peripheral.instance.getDrive(driveAddr);
 
 			if (drive == null){
 				handle.writeLine("Drive not found: " + driveAddr);
+				return false;
 			}
 
 			if (!drive.isDiskPresent()){
 				handle.writeLine("No disk in drive: " + driveAddr);
+				return false;
 			}
 
 			drive.ejectDisk();
-			case "lable":
+			return true;
+		},"<drive>");
+
+		registerSyncSubcommand("lable",(args) -> {
+			if (args.length < 1){
+				handle.writeLine("Missing drive address");
+				return false;
+			}
+
+			var driveAddr = args[0];
 			var drive = Peripheral.instance.getDrive(driveAddr);
-				var label:String = handle.args[2];
+			var label:String = args[1];
 
 			if (drive == null){
 				handle.writeLine("Drive not found: " + driveAddr);
@@ -99,26 +93,38 @@ class Disk implements Process {
 				var err  = drive.setDiskLabel(label);
 				if (err != null){
 					handle.writeLine("Failed to set lable");
+					return false;
 				}
 			}
-			case "help":
-			case null:
-				printHelp();
-			default:
-				handle.writeLine("Unknown subcommand: " + subcommand);
-				printHelp();
-		}
 
-		return handle.close(true);
+			return true;
+		},"<drive> [label]");
 	}
 
-	private function printHelp() {
-		handle.writeLine("Usage: disk <subcommand> [args]");
-		handle.writeLine("Subcommands:");
-		handle.writeLine("  ls");
-		handle.writeLine("  play <drive>");
-		handle.writeLine("  stop <drive>");
-		handle.writeLine("  eject <drive>");
-		handle.writeLine("  label <drive> [label]");
+	private function audioDiskPlayPause(driveAddr: String, play: Bool): Bool {
+		var drive = Peripheral.instance.getDrive(driveAddr);
+
+		if (drive == null){
+			handle.writeLine("Drive not found: " + driveAddr);
+			return false;
+		}
+
+		if (!drive.isDiskPresent()){
+			handle.writeLine("No disk in drive: " + driveAddr);
+			return false;
+		}
+
+		if (!drive.hasAudio()){
+			handle.writeLine("Disk in drive: " + driveAddr + " does not have audio");
+			return false;
+		}
+
+		if (play){
+			drive.playAudio();
+		}else{
+			drive.stopAudio();
+		}
+
+		return true;
 	}
 }

src/bin/GPS.hx

@@ -1,60 +1,15 @@
 package bin;
 
-import kernel.ps.ProcessHandle;
-import kernel.ps.Process;
+import lib.CLIAppBase;
 import kernel.gps.INS;
 import lib.Pos3;
 import lib.Vec.Vec3;
 
 using tink.CoreApi;
 
-class GPS implements Process {
-	private var handle:ProcessHandle;
-
-	public function new() {}
-
-	public function run(handle: ProcessHandle):Void {
-		this.handle = handle;
-
-		var subcommand = handle.args[0];
-		var subcommand_args = handle.args.slice(1);
-
-		switch (subcommand) {
-			case "set":
-				handle.close(setManuelPos(subcommand_args));
-			case "status":
-				handle.close(getGPSStatus());
-			case "locate":
-				kernel.gps.GPS.instance.locate().handle((pos)->{
-					if (pos != null) {
-						handle.writeLine('Position x:${pos.x} y:${pos.y} z:${pos.z}');
-						handle.close(true);
-					} else {
-						handle.writeLine("Position not available");
-						handle.close(false);
-					}
-				});
-			case "ins":
-				INS.instance.align().handle(()->{
-					handle.writeLine("INS aligned");
-					handle.close(true);
-				});
-			default:
-				handle.writeLine("Unknown subcommand: " + subcommand);
-				printHelp();
-				handle.close(false);
-		}
-	}
-
-	private function printHelp(){
-		handle.writeLine("GPS commands:");
-		handle.writeLine("set <x> <y> <z> - set manual position");
-		handle.writeLine("status - get current position and accuracy");
-		handle.writeLine("locate - get current position");
-		handle.writeLine("ins - align INS");
-	}
-
-	private function setManuelPos(args: Array<String>): Bool {
+class GPS extends CLIAppBase {
+	public function new() {
+		registerSyncSubcommand("set", (args)->{
 			var x: Float = Std.parseFloat(args[0]);
 			var y: Float = Std.parseFloat(args[1]);
 			var z: Float = Std.parseFloat(args[2]);
@@ -64,10 +19,9 @@ class GPS implements Process {
 			kernel.gps.GPS.instance.setManualPosition(pos);
 	
 			return true;
-	}
-
-	private function getGPSStatus(): Bool {
+		},"<x> <y> <z>");
 
+		registerSyncSubcommand("status",(args)->{
 			var pos = kernel.gps.GPS.instance.getPosition();
 			if (pos != null) {
 				handle.writeLine('Position x:${pos.x} y:${pos.y} z:${pos.z}');
@@ -93,5 +47,24 @@ class GPS implements Process {
 			}
 	
 			return true;
+		});
+
+		registerAsyncSubcommand("locate",(args)->{
+			return kernel.gps.GPS.instance.locate().map((pos)->{
+				if (pos != null) {
+					handle.writeLine('Position x:${pos.x} y:${pos.y} z:${pos.z}');
+				} else {
+					handle.writeLine("Position not available");
+				}
+				return true;
+			});
+		});
+
+		registerAsyncSubcommand("ins",(args)->{
+			return INS.instance.align().map((_)->{
+				handle.writeLine("INS aligned");
+				return true;
+			});
+		});
 	}
 }

src/bin/Net.hx

@@ -1,102 +1,65 @@
 package bin;
 
-import kernel.ps.ProcessHandle;
-import kernel.ps.Process;
+import lib.CLIAppBase;
 import kernel.peripherals.Peripherals.Peripheral;
 import kernel.net.Routing;
-import haxe.ds.ReadOnlyArray;
 
 using tink.CoreApi;
 
-class Net implements Process {
-	private var handle:ProcessHandle;
-
-	public function new() {}
-
-	public function run(handle:ProcessHandle):Void {
-		this.handle = handle;
-
-		var subcommand = handle.args[0];
-		var subcommand_args = handle.args.slice(1);
-
-		switch (subcommand) {
-			case "route":
-				route(subcommand_args);
-				return handle.close();
-			case "iface":
-				iface(subcommand_args);
-				return handle.close();
-			case "help":
-				printHelp();
-				return handle.close();
-			case "ping":
-				ping(subcommand_args);
-				// Closes itself
-			case "proto":
-				protos();
-				return handle.close();
-			default:
-				handle.write("Unknown subcommand: " + subcommand);
-				printHelp();
-				return handle.close(false);
-		}
-	}
-
-	private function printHelp() {
-		handle.write("net route");
-		handle.write("net iface");
-		handle.write("net help");
-		handle.write("net proto");
-	}
-
-	private function route(args:ReadOnlyArray<String>):Void {
+class Net extends CLIAppBase {
+	public function new() {
+		registerSyncSubcommand("route", (args)->{
 			var routes = Routing.instance.getRouteTable();
 
 			for(k => v in routes) {
-			handle.write('${k} => ${v.interf.name()}(${v.cost})');
-		}
-	}
-
-	private function iface(args:ReadOnlyArray<String>):Bool {
-		var modems = Peripheral.instance.getModems();
-
-		for (modem in modems) {
-			handle.write(modem.name());
+				handle.writeLine('${k} => ${v.interf.name()}(${v.cost})');
 			}
 
 			return true;
+		});
+
+		registerSyncSubcommand("iface", (args)->{
+			var modems = Peripheral.instance.getModems();
+
+			for (modem in modems) {
+				handle.writeLine(modem.name());
 			}
 
-	function ping(args:ReadOnlyArray<String>): Void {
-		if (args.length != 1) {
-			handle.write("Usage: net ping id");
-			return handle.close(false);
+			return true;
+		});
+
+		registerSyncSubcommand("proto",(args)->{
+			var protos = kernel.net.Net.instance.getActiveProtocols();
+
+			for (proto in protos) {
+				handle.writeLine(proto);
+			}
+
+			return true;
+		});
+
+		registerAsyncSubcommand("ping",(args)->{
+			if (args.length < 1) {
+				return Future.sync(false);
 			}
 	
 			var toID:Null<Int> = Std.parseInt(args[0]);
 	
 			if (toID == null) {
 				handle.write("Invalid ID");
-			return handle.close(false);
+				return Future.sync(false);
 			}
 	
-		kernel.net.Net.instance.ping(toID).handle(result -> {
+			return kernel.net.Net.instance.ping(toID).map(result -> {
 				switch (result){
 					case Success(_):
 						handle.write("Ping succeeded");
-					return handle.close();
 					case Failure(failure):
 						handle.write("Ping failed: " + failure);
-					return handle.close(false);
 				}
+
+				return true;
 			});
-	}
-
-	function protos():Void {
-		var protos = kernel.net.Net.instance.getActiveProtocols();
-
-		for (proto in protos) {
-			handle.write(proto);
-		}
+		},"<id>");
 	}
 }

src/bin/Redstone.hx

@@ -1,44 +1,26 @@
 package bin;
 
-import kernel.ps.ProcessHandle;
-import kernel.ps.Process;
+import lib.CLIAppBase;
 import kernel.peripherals.Peripherals.Peripheral;
-import kernel.peripherals.Side;
 
 using tink.CoreApi;
 
-class Redstone implements Process {
-	public function new() {}
+class Redstone extends CLIAppBase{
+	public function new() {
+		registerSyncSubcommand("on", (args)-> {
+			Peripheral.instance.getRedstone(args[0]).setOutput(true);
+			return true;
+		});
 
-	public function run(handle: ProcessHandle):Void {
-		var subcommand = handle.args[0];
+		registerSyncSubcommand("off", (args)-> {
+			Peripheral.instance.getRedstone(args[0]).setOutput(false);
+			return true;
+		});
 
-		if (subcommand == null) {
-			handle.write("Usage: redstone <on|off|get> <side>");
-			return handle.close(false);
-		}
-
-		var side:Null<Side> = handle.args[1];
-		if (side == null) {
-			handle.write("Invalid side");
-			return handle.close(false);
-		}
-
-		switch (subcommand) {
-			case "on":
-				Peripheral.instance.getRedstone(side).setOutput(true);
-			case "off":
-				Peripheral.instance.getRedstone(side).setOutput(false);
-			case "get":
-				var value = Peripheral.instance.getRedstone(side).getAnalogInput();
+		registerSyncSubcommand("get", (args)-> {
+			var value = Peripheral.instance.getRedstone(args[0]).getAnalogInput();
 			handle.write("Analog input: " + value);
-			case "help":
-				handle.write("Usage: redstone <on|off|get> <side>");
-			default:
-				handle.write("Invalid subcommand");
-				return handle.close(false);
-		}
-
-		return handle.close();
+			return true;
+		});
 	}
 }

src/bin/Terminal.hx

@@ -117,11 +117,24 @@ class Terminal implements Process {
 		ProcessManager.run(ps,{
 			args: commandArgs,
 			onWrite: (s:String) -> {
+				if (s == "") {
+					return;
+				}
+
 				if (!hadInput) {
+					// Add a new line, so that the input is not on the same line as the command
 					this.backlog.push("");
 					hadInput = true;
 				}
+
+				for (line in s.split("\n")) {
+					if (line == ""){
+						this.backlog.push("");
+					} else {
 						this.backlog[this.backlog.length - 1] += s;
+					}
+				}
+				
 				this.requestRender();
 			},
 			onExit: (success:Bool) -> {

src/kernel/ps/ProcessHandle.hx

@@ -20,6 +20,7 @@ class ProcessHandle {
 	private final closeFuture: Future<Bool>;
 	private var closeFutureResolev: Bool -> Void;
 	private final windowContexts: Array<WindowContext> = [];
+	private final cbLinks:Array<CallbackLink> = [];
 
 	@:allow(kernel.ps.ProcessManager)
 	private function new(config: HandleConfig,pid: PID) {
@@ -34,8 +35,6 @@ class ProcessHandle {
 		if (this.config.onExit != null) {
 			this.closeFuture.handle(this.config.onExit);
 		}
-
-		this.closeFuture.eager();
 	}
 
 	public function onExit(): Future<Bool> {
@@ -75,7 +74,17 @@ class ProcessHandle {
 	}
 
 	private function dispose() {
-		// TODO
+		for (link in this.cbLinks) {
+			link.cancel();
+		}
+	}
+
+	public function getPid(): PID {
+		return this.pid;
+	}
+
+	public function addCallbackLink(link: CallbackLink) {
+		this.cbLinks.push(link);
 	}
 
 	function get_args():ReadOnlyArray<String> {

src/lib/CLIAppBase.hx

@@ -40,12 +40,12 @@ abstract class CLIAppBase implements Process {
 
 	private function registerSyncSubcommand(command: String, callback: (Array<String>) -> Bool, synopsis: String = null) {
 		_subcommandsSync.set(command, callback);
-		_subcommandsSynopsis.push(command + " " + synopsis);
+		_subcommandsSynopsis.push(command + " " + (synopsis ?? ""));
 	}
 
 	private function registerAsyncSubcommand(command: String, callback: (Array<String>) -> Future<Bool>, synopsis: String = null) {
 		_subcommandsAsync.set(command, callback);
-		_subcommandsSynopsis.push(command + " " + synopsis);
+		_subcommandsSynopsis.push(command + " " + (synopsis ?? ""));
 	}
 
 	private function printHelp() {